View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001434 | The World of Secfenia | Other | public | 2019-05-15 23:02 | 2019-05-21 20:04 |
| Reporter | Marleen | Assigned To | daviceroy | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Target Version | 3.1.006 | Fixed in Version | 3.1.006 | ||
| Summary | 0001434: very bad html structure | ||||
| Description | I took a look at the source code of a page to try to determine the framework/language (I'm thinking it's no-framework PHP), and discovered that the HTML structure has gotten a bit mangled over time. Everyone looses quotes and tags here and there but the major structure of the page is super important and it's about two straws away from failing the next time anything major is added to the page like a Jenga tower. (1) There is an external stylesheet, scripts, and internal script above the <!DOCTYPE tag (2) There are two HTML tags, one below DOCTYPE and one inside the BODY, nestled between the favicon and title (3) After the ending of the HEAD tag there is another META tag and an internal stylesheet (should be inside the HEAD) It is not a huge issue, but you may have a performance gain by putting the stylesheet as an external stylesheet so that the browser can cache it. (4) inside the BODY, things are pretty ok, some missing tags here and there and that happens, but there does not seem to be an end BODY and end HTML tag and those are pretty major Another small other performance gains to be had is to change the dimensions of these this files to 1 x 1 as it's a repeated background and it takes the longest to load on the page: https://www.secfenia.org/images/bg/bgtile.png | ||||
| Tags | No tags attached. | ||||
|
|
Secfenia's codebase isn't part of any PHP Framework at this time. I will admit that the page has had a number of tweaks over the past decade and I've tried to clean it up from time to time, but with the quantity of lines in the code and the fact that I'm the only coder it means there are definitely times when things get unmatched or not as clean as even I would like. If you notice any additional issues, please feel free to let me know. Issue 1 does not appear on the main page. What page were you on? It's probably one where the username script is for the dropdown? Issue 2 will be fixed in 3.1.006. Combining them into one at the top. |
|
|
Issue 3 will be fixed in 3.1.006 with a revised stylesheet that removes some of the old CSS code that is no longer in use. It was always a separate style sheet, but was being preloaded into each page by PHP. Moved the META tag to the header Issue 4: End BODY and end HTML tabs are technically optional per the W3 standards in the case where they are being used, but this is more of a matter where the end tags were probably accidentally removed along the 10 year journey. Issue 5: I think the original reason why it was repeated at that size is because there is a gradient in the color as what the original creator of it stated. I'll run some test to check some things, but reducing the size of it is definitely on my agenda. |
|
|
Player profile code slightly alter for Issue 1. Issue 5 image is now reduced. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-05-15 23:02 | Marleen | New Issue | |
| 2019-05-15 23:02 | Marleen | Status | new => assigned |
| 2019-05-15 23:02 | Marleen | Assigned To | => daviceroy |
| 2019-05-16 22:31 | daviceroy | Status | assigned => acknowledged |
| 2019-05-16 22:31 | daviceroy | Note Added: 0001017 | |
| 2019-05-17 21:04 | daviceroy | Note Added: 0001018 | |
| 2019-05-21 19:56 | daviceroy | Target Version | => 3.1.006 |
| 2019-05-21 20:04 | daviceroy | Note Added: 0001019 | |
| 2019-05-21 20:04 | daviceroy | Status | acknowledged => resolved |
| 2019-05-21 20:04 | daviceroy | Resolution | open => fixed |
| 2019-05-21 20:04 | daviceroy | Fixed in Version | => 3.1.006 |
